ok to test

@MechCoder Could you help review this PR? Thanks!

Test build #38755 has finished for PR 7729 at commit 2e5ebd6.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

@MechCoder Thanks for pointing that out. I agree that the tag might not be necessary for the sealed trait. Let me know if you come across anything else.

Test build #39377 has finished for PR 7729 at commit 3be09e9.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

Thanks for the PR. I'm also not sure if tags should be added for hashcode, equals etc since the user is not going to access these features through the documentation.

@MechCoder thank you for the very detailed review! I have made most of the changes that you had pointed out except for the following:

• I left the tags on the alternative constructor for the public classes as I thought it would be useful to know when it was introduced.
• I left the tag in the DistributedMatrix as it is not a sealed trait and would be accessible.

In addition to the above:

• I removed the tags from the hashCode and equals methods based on your comment. The only exception is the toString method in the DenseVector and SparseVector classes.

Let me know if you spot something else. Thanks again.

Test build #39634 has finished for PR 7729 at commit 3012864.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

I left the tags on the alternative constructor for the public classes.

Then could you make the tags availble for all the alternative constructors. eg. DenseMatrix

@MechCoder I couldnt find the untagged alternate constructor in DenseMatrix. Can you point me to where you see it?

That's it apart from those couple of comments.

We don't need to add since tags for methods inherited from Java Object like toString, hashCode, and equals. @sabhyankar Could you address @MechCoder 's comments? We should merge this before the 1.5 RC release.

I am going to take a look at this and update the PR by tomorrow.

test this please

@MechCoder Could you make another pass? Thanks!

I removed the tags from two of the toString method and confirmed left the tags in place for the alternate constructors as mechcoder mentioned.